Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumpup cosmjs 0.30.1 #84

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Bumpup cosmjs 0.30.1 #84

merged 9 commits into from
Mar 31, 2023

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Mar 27, 2023 •
edited
Loading

In this PR, bumped cosmjs up to version 0.30.1.
Additionally, there was a change in the eslint settings, so it was applied.

After this PR, please run yarn run lint-fix before upload PR.

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 self-assigned this Mar 28, 2023
@loin3 loin3 linked an issue Mar 28, 2023 that may be closed by this pull request
bump up cosmjs to 0.30.1 #83
Closed
@loin3 loin3 requested a review from zemyblue March 31, 2023 04:52
@tkxkd0159
Copy link
Member

tkxkd0159 commented Mar 31, 2023 •
edited
Loading

nit: I think it's better to use original wasmTypes and just extend this with MsgInstantiate2Contract like below

[["/cosmwasm.wasm.v1.MsgInstantiate2Contract, MsgInstantiate2Contract"], ...wasmTypes]]

@loin3
Copy link
Contributor Author

loin3 commented Mar 31, 2023

Yes I wanted to use wasmTypes in cosmjs.
but currently it is not exported correctly. that is why lbmjs has wasm module while every cosmwasm modules are separated from ours and we have our specific module wasmplus.
I made an issue about this in cosmjs (cosmos/cosmjs#1397). so lbmjs wasm module could be deleted in later version.

@loin3 loin3 requested a review from zemyblue March 31, 2023 08:11
@loin3 loin3 merged commit 5473a0e into main Mar 31, 2023
@loin3 loin3 deleted the bumpup_0.30.1 branch April 13, 2023 11:16
@zemyblue zemyblue mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

@zemyblue zemyblue zemyblue approved these changes

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

@0Tech 0Tech Awaiting requested review from 0Tech

@dudong2 dudong2 Awaiting requested review from dudong2

Assignees

@loin3 loin3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump up cosmjs to 0.30.1
3 participants
@loin3 @tkxkd0159 @zemyblue