This repository has been archived by the owner on Jul 14, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add integration tests for all active and maintained components to show that they can all be bundled correctly with the service #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he integration tests
…or maintained and have JavaScript are able to be bundled via the JavaScript bunding API endpoint
…es that a real DOM would have
… This is the case when a bower component has been published that has not included it's bower.json file
…gs off when running tests
…d currently are written in a way which is not valid browser-based JavaScript
chee
reviewed
May 28, 2019
chee
reviewed
May 28, 2019
chee
reviewed
May 28, 2019
chee
reviewed
May 28, 2019
chee
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests ensure that any changes to the service will always work with the latest version of active and maintained origami components.
It has found a few bugs in some components and some bugs in the new origami build service, which is great :-)