Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TestData object to allow more tests to run #474

Merged
merged 25 commits into from
Jun 9, 2023
Merged

Set TestData object to allow more tests to run #474

merged 25 commits into from
Jun 9, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jun 6, 2023 •
edited
Loading

Closes #294.

A naive attempt at solving #294 just to allow more tests to run.

@b1ron b1ron self-assigned this Jun 6, 2023
@b1ron b1ron added the code/chore Dance tool code maintenance improvements label Jun 6, 2023
@b1ron b1ron marked this pull request as ready for review June 7, 2023 09:40
@b1ron b1ron requested review from a team as code owners June 7, 2023 09:40
@b1ron b1ron requested review from AlekSi and rumyantseva June 7, 2023 09:40
@b1ron b1ron enabled auto-merge (squash) June 7, 2023 09:41
@AlekSi AlekSi removed request for a team and rumyantseva June 7, 2023 12:34
AlekSi
AlekSi reviewed Jun 7, 2023
View reviewed changes
internal/jstest/jstest.go Outdated Show resolved Hide resolved
internal/jstest/jstest.go Outdated Show resolved Hide resolved
@b1ron
Copy link
Contributor Author

b1ron commented Jun 7, 2023 •
edited
Loading

Those uncaught exception: ReferenceError: can't access lexical declaration 'ret' before initialization : errors are not related to this PR. They seem to related to files that don't invoke themselves as a function. I tested this manually and on MongoDB versions 6.0.6 and 6.0.3. This file for example will cause the error.

@b1ron b1ron requested a review from AlekSi June 7, 2023 13:47
b1ron
b1ron commented Jun 8, 2023
View reviewed changes
internal/jstest/jstest.go Outdated Show resolved Hide resolved
@b1ron
Copy link
Contributor Author

b1ron commented Jun 9, 2023

@AlekSi PTAL

AlekSi
AlekSi approved these changes Jun 9, 2023
View reviewed changes
internal/jstest/jstest.go Outdated Show resolved Hide resolved
internal/jstest/jstest.go Outdated Show resolved Hide resolved
internal/jstest/jstest.go Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Jun 9, 2023
View reviewed changes
internal/jstest/jstest.go Outdated Show resolved Hide resolved
AlekSi
AlekSi previously approved these changes Jun 9, 2023
View reviewed changes
internal/jstest/jstest.go Outdated Show resolved Hide resolved
@b1ron b1ron requested a review from AlekSi June 9, 2023 12:56
@b1ron b1ron merged commit 3fb1a6a into FerretDB:main Jun 9, 2023
@b1ron b1ron deleted the set-testdata branch July 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees

@b1ron b1ron

Labels
code/chore Dance tool code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate how we can set the TestData object
2 participants
@b1ron @AlekSi