fix: CLIN-2916 fix saving custom filter after adding saved custom pill to it #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meek0
force-pushed
the
fix/clin-2916
branch
2 times, most recently
from
3e3b02b to
654732e
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
0 tests passing in 0 suite.
Report generated by 🧪jest coverage report action from f7f936f
Project Coverage and TestStatements : 35.58% ( 10446/29358 ) Test Suites: 56 passed, 56 total |
meek0
force-pushed
the
fix/clin-2916
branch
4 times, most recently
from
8067dcd to
d00bd7e
Compare
emmanuelnau
reviewed
Aug 9, 2024
packages/ui/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@ferlab/ui", | |||
| "version": "10.4.6", | |||
| "version": "10.4.7-rc1", | |||
There was a problem hiding this comment.
je pense que tu as pas fait le npm install car le packag-lock.json devrait aussi avoir la version mise à jour
There was a problem hiding this comment.
en effet, fixing it now
emmanuelnau
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX
Description
JIRA LINK
Acceptance Criterias
Validation