Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Performance Optimizations #191

Merged
merged 29 commits into from
Jun 9, 2022
Merged

Major Performance Optimizations #191

merged 29 commits into from
Jun 9, 2022

Conversation

FelixKratz
Copy link
Owner

@FelixKratz FelixKratz commented Jun 7, 2022

This is a full rewrite of the entire drawing logic of the bar. The cpu utilization, especially in animations, should be 3-6x lower than before. But since I have rewritten most of the drawing logic some testing has to be done before I merge this into master.

Everything should look and work exactly like before, just much faster.
So if you want to help me with the testing of this implementation please do so by running the following commands:

git clone https://github.com/FelixKratz/SketchyBar.git SketchyBar
cd SketchyBar && git checkout picky_redraw
brew services stop sketchybar && killall sketchybar
make && ./bin/sketchybar

see if everything is still working and looks the same as before. Please also report back if everything still works like before.

I will test this new implementation myself for a week at least before merging it to master and creating a new release.

@FelixKratz
Copy link
Owner Author

I think this should be save to merge for now. Testing continues on master, so please open an issue if you encounter problems.

@FelixKratz FelixKratz merged commit 9e02b7e into master Jun 9, 2022
@FelixKratz FelixKratz deleted the picky_redraw branch June 9, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant