Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets effecting "click" for click scripts #216

Closed
robbierobs opened this issue Jul 18, 2022 · 1 comment
Closed

Brackets effecting "click" for click scripts #216

robbierobs opened this issue Jul 18, 2022 · 1 comment
Labels
available on master bug Something isn't working

Comments

@robbierobs
Copy link

I've noticed significant issues while trying to execute click scripts on bracketed items. It almost seems like the click is happening on the bracket itself and possibly not the item.

Clicking multiple times or across the items to find a "sweet spot" works mostly.

@FelixKratz
Copy link
Owner

Thanks for reporting. I think I know why that is:

EVENT_CALLBACK(EVENT_HANDLER_MOUSE_UP) {

In this function I first get the bar item by its wid (which is only the pixel perfect rendering region without the transparent regions) and if that fails I get the item by its bounding rectangle. In a bracket the second step is never executed, as it will instead register the click for the bracket wid if the cursor is not perfectly above the rendering of a bracketed item.

Should be a fairly easy fix, will take care of this as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available on master bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants