Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forbid extra keys option #198

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Conversation

mishamsk
Copy link
Contributor

Split from #183

Closes #197

@pep8speaks
Copy link

pep8speaks commented Mar 13, 2024

Hello @mishamsk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-13 20:25:10 UTC

@Fatal1ty Fatal1ty merged commit 4ef0c95 into Fatal1ty:master Mar 31, 2024
16 checks passed
@Fatal1ty
Copy link
Owner

Fatal1ty commented Mar 31, 2024

Thanks!

I returned table and list formatting back and changed the way how we're searching for a discriminator in superclasses to fix a bug when an intermediate superclass has a config without a discriminator. I made the decision to merge it with my edits so as not to delay the already protracted PR.

Edit: This is why I did the formatting for tables:
Снимок экрана 2024-03-31 в 15 32 04

@mishamsk mishamsk deleted the forbid-extra-keys branch July 3, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject extra keys on deserialization
3 participants