-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schema evolution involving maps of non-scalar #211
Fix schema evolution involving maps of non-scalar #211
Conversation
Merged. The reason I am not sure about 2.10 release is just low number of fixes as per https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10.5 (and since this is likely the last full patch set for 2.10) whereas many more for 2.11: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.11.1 and so if possible it'd be great to verify that 2.10->2.11 could work for your use case. |
Hmmmh. Looks like this change broke 2.12 tests :-( |
.... or maybe it was already broken. Need to check into failure. Will add a note if I find something related to this change. |
both 2.10 and 2.11 works for us, we just need a released version including the fix, so choose whatever requires less time of yours :) About the broken tests, it's weird because the fix is a one-line change that is clearly a mistake (the test is the proof). |
@marcospassos I think it is unrelated to this change, apologies for false alarm. It is related to coercion config changes in 2.12 somehow, need to figure out exactly how. Thanks wrt 2.10/2.11; just wanted to know if you had specific constraints at this point. |
Ah. Interesting. Databind wrongly prevent coercion from "Blank string" for |
Hey @cowtowncoder! Any idea on when it will be released? |
@marcospassos I'll have to think of when to release 2.10.5: it might be the last 2.10 patch release and there haven't been that many fixes. So there's some balancing wrt how long to wait. But I think this fix was included in 2.11.1 which has been released, if you can use that version? |
Rework on branch 2.10, surpasses #210.
@cowtowncoder I've added tests to prevent regression as you asked.
Just reiterating, if possible, releasing a patch anytime soon would help us a lot :)
Please, let me know if you need anything else.