Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema evolution involving maps of non-scalar #211

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix schema evolution involving maps of non-scalar #211

merged 1 commit into from
Jun 23, 2020

Conversation

marcospassos
Copy link
Contributor

Rework on branch 2.10, surpasses #210.

@cowtowncoder I've added tests to prevent regression as you asked.

Just reiterating, if possible, releasing a patch anytime soon would help us a lot :)

Please, let me know if you need anything else.

@marcospassos marcospassos changed the base branch from master to 2.10 June 22, 2020 12:25
@cowtowncoder cowtowncoder merged commit 518374a into FasterXML:2.10 Jun 23, 2020
@cowtowncoder cowtowncoder added this to the 2.10.5 milestone Jun 23, 2020
cowtowncoder added a commit that referenced this pull request Jun 23, 2020
@cowtowncoder
Copy link
Member

Merged. The reason I am not sure about 2.10 release is just low number of fixes as per

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10.5

(and since this is likely the last full patch set for 2.10)

whereas many more for 2.11:

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.11.1

and so if possible it'd be great to verify that 2.10->2.11 could work for your use case.
Every new full patch release takes 2-3 hours for me so I will need to balance time available on cutting releases.

@cowtowncoder
Copy link
Member

Hmmmh. Looks like this change broke 2.12 tests :-(

@cowtowncoder
Copy link
Member

.... or maybe it was already broken. Need to check into failure. Will add a note if I find something related to this change.

@marcospassos
Copy link
Contributor Author

marcospassos commented Jun 23, 2020

both 2.10 and 2.11 works for us, we just need a released version including the fix, so choose whatever requires less time of yours :)

About the broken tests, it's weird because the fix is a one-line change that is clearly a mistake (the test is the proof).

@cowtowncoder
Copy link
Member

@marcospassos I think it is unrelated to this change, apologies for false alarm. It is related to coercion config changes in 2.12 somehow, need to figure out exactly how.

Thanks wrt 2.10/2.11; just wanted to know if you had specific constraints at this point.

@cowtowncoder
Copy link
Member

Ah. Interesting. Databind wrongly prevent coercion from "Blank string" for Character, in case of a single white space characted. Something databind did not test but Avro module does.... Nice indirect catch. :)

@marcospassos
Copy link
Contributor Author

Hey @cowtowncoder! Any idea on when it will be released?

@marcospassos marcospassos deleted the fix-schema-evolution branch July 10, 2020 19:47
@cowtowncoder
Copy link
Member

@marcospassos I'll have to think of when to release 2.10.5: it might be the last 2.10 patch release and there haven't been that many fixes. So there's some balancing wrt how long to wait.

But I think this fix was included in 2.11.1 which has been released, if you can use that version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants