Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New namelist parameters for Held-Suarez forcing and spectral dynamics #32

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

gregcolyer
Copy link
Collaborator

Adds P00 (reference pressure used in Held-Suarez, not necessarily the same as surface pressure) to the namelist, and a new parameter lapse_rate for [adiabatic] lapse rate normalized to dry. lapse_rate is used only for classic newtonian_damping (original and exoplanet variants); there is also a similar but dimensional parameter lapse used only for top_down_newtonian_damping; the two could be consolidated (not done).

Also adds a new parameter reference_temp to the spectral dynamics namelist, previously hard-coded to 300 K.

@sit23
Copy link
Contributor

sit23 commented Dec 14, 2017

Looks fine to me, but happy to defer this to @Alexander-P and @jamesp as I don't ever use the Held-Suarez bit of the code.

@jamesp
Copy link
Contributor

jamesp commented Dec 14, 2017

Looks good. We should probably get rid of the alpha parameter that I added (and haven't really used) as this achieves the same thing

@gregcolyer
Copy link
Collaborator Author

Ah yes, I didn't notice alpha. Same as (KAPPA*lapse_rate)?

@jamesp
Copy link
Contributor

jamesp commented Dec 14, 2017

Yep. In fact, let's just scrap the EXOPLANET2 conditional branch altogether

@alex-r-p
Copy link
Contributor

I didn't notice that there was an existing normalized lapse rate thing, I may look into using that for top_down. This looks good to me

@gregcolyer
Copy link
Collaborator Author

There wasn't until now

@jamesp
Copy link
Contributor

jamesp commented Dec 14, 2017

thanks @gregcolyer, I was just doing this!

@alex-r-p
Copy link
Contributor

good reading comprehension, me!

@gregcolyer
Copy link
Collaborator Author

I think the default lapse (in K/km?) corresponds to a lapse_rate of 2/3, whereas 1 is needed for standard Held-Suarez. We could code different defaults for classic and top_down though, if you want to keep top_down the same.

@gregcolyer
Copy link
Collaborator Author

Following discussion with @Alexander-P: no need for different defaults, so I will code up this consolidation (remove lapse from namelist but set based on lapse_rate) and push here

@gregcolyer gregcolyer requested a review from alex-r-p December 15, 2017 17:25
@gregcolyer
Copy link
Collaborator Author

Side note: P00 defaults to 1E5 exactly, as in the Held-Suarez paper; this does not have to equal the reference surface pressure, but for consistency one should presumably set the latter to 1E5 (i.e. override the more precise default value) in the typical case. It's probably not appropriate to change either default (one should match the paper, the other should be the best available value for Earth), but perhaps the code should warn if they differ only by this order (i.e. a few per cent)?

@jamesp
Copy link
Contributor

jamesp commented Sep 4, 2018

Shall we put this in, @gregcolyer?

@gregcolyer
Copy link
Collaborator Author

Testing now

@dennissergeev dennissergeev added dyn:spectral Dynamics: spectral core idealised Idealised setup: Single-Column, Held-Suarez, etc. priority:low Low-priority task labels May 6, 2020
@rosscastle rosscastle added the model_dev Isca development for new features, but not fixes label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dyn:spectral Dynamics: spectral core idealised Idealised setup: Single-Column, Held-Suarez, etc. model_dev Isca development for new features, but not fixes priority:low Low-priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants