-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New namelist parameters for Held-Suarez forcing and spectral dynamics #32
base: master
Are you sure you want to change the base?
Conversation
…ded 300 K) to spectral namelist; cf. Simmons et al. 1978
Looks fine to me, but happy to defer this to @Alexander-P and @jamesp as I don't ever use the Held-Suarez bit of the code. |
Looks good. We should probably get rid of the |
Ah yes, I didn't notice |
Yep. In fact, let's just scrap the EXOPLANET2 conditional branch altogether |
I didn't notice that there was an existing normalized lapse rate thing, I may look into using that for top_down. This looks good to me |
There wasn't until now |
thanks @gregcolyer, I was just doing this! |
good reading comprehension, me! |
I think the default |
Following discussion with @Alexander-P: no need for different defaults, so I will code up this consolidation (remove |
Side note: |
Shall we put this in, @gregcolyer? |
Testing now |
Adds
P00
(reference pressure used in Held-Suarez, not necessarily the same as surface pressure) to the namelist, and a new parameterlapse_rate
for [adiabatic] lapse rate normalized to dry.lapse_rate
is used only for classic newtonian_damping (original and exoplanet variants); there is also a similar but dimensional parameterlapse
used only for top_down_newtonian_damping; the two could be consolidated (not done).Also adds a new parameter
reference_temp
to the spectral dynamics namelist, previously hard-coded to 300 K.