Vertical Coordinate Docs #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw538
added
docs
priority:medium
sit23
previously requested changes
Jul 30, 2021
There was a problem hiding this comment.
This is great Dan, nice work. I've made a few suggestions, but they're relatively minor. One other thing you might say is to note that the output of the model is on the levels you prescribe in this module (i.e. on sigma levels if you ask for sigma), and therefore it needs to be interpolated to standard pressure levels for interpretation. You could then link to any interpolator documentation should this exist already, or point to it being forthcoming.
|
Thanks Stephen for the feedback -- think I've manged to address and integrate everything you've suggested into the new version. |
rosscastle
removed
priority:medium
daw538
dismissed
sit23’s stale review
Points raised in initial review have now been address. Closing to allow merge into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of docs page for the
vert_coordinate.f90module, used to control the model levels used in a run.Suggestions/improvements welcome, especially if you spot a typo.