Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-Currency Money - Kent Beck: Test Driven Development by Example #3

Open
EthanLin-TWer opened this issue Jan 2, 2017 · 0 comments
Open

Multi-Currency Money - Kent Beck: Test Driven Development by Example #3

EthanLin-TWer opened this issue Jan 2, 2017 · 0 comments
Assignees
@EthanLin-TWer

Comments

@EthanLin-TWer
Copy link
Owner

EthanLin-TWer commented Jan 2, 2017 •
edited
Loading

No description provided.

@EthanLin-TWer EthanLin-TWer self-assigned this Jan 2, 2017
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, change times() in Dollar&France class to return a Money
7ec761a
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, pull times() method up to super Money class
3b69719
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Remove comment, no duplication now
3e76556
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, remove reference to Dollar&France and remove duplicate…
395503e 
…d tests
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, move Dollar/France tests to Money before delete these …
9d1030f 
…classes
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, remove Dollar class and France class and their test cl…
bf39ced 
…asses
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Enable IDE to use gradle with sources so gradle DSL/docs can be …
cd225ba 
…present
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Update cobertura version from 2.3.2 to 2.4.0
66f3cac
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Delete Library/LibraryTest initialized by gradle init plugin
e61d430
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Setup cobertura to work on travis
60efebd
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Run coberturaCheck in travis but skipped all coverage check for now
e5a14c6 
See todo: Cobertura cannot work with JUnit 5 right now.
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Fix syntax error in .travis.yml, add space between task name and…
d86706b 
… args
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Add addition test, should 5 dollars + 5 dollars = 10 dollars
8968e39
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, use real implementation rather than harcoded 10 dollars
1f4f73e
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Use test to express the design, as Kent Beck suggested in his book
61fb649
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Assert plus() should return Sum object which contains augend&addend
f853f69
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, use passed in parameters in Sum constructor
5e8131d
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Modify test to use $50 and pass in real augend&addends
a42819f
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, Use Intellij built-in 'Encapsulate field' suggestion
0204397
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Add test: Bank should reduced money with same currency
5c0404b
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Add three todos
9fb3b1b
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, move reduce logic to Sum since it uses more data from Sum
d3d0a55
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Wording, refine todo
fa8462d
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Should bank.reduced() return Money object when expression is Mon…
d0b0b24 
…ey type
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Remove no used parameter
9081fe0
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, pull reduced() as interface method and impl it in Money
5ff4462
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, remove casts and use polymorphism to impl reduced() in…
f1b5532 
…stead
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Refactor, rename reduced() to reduce()
1a5d983
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Rename package from org.thoughtworks.linesh to tdd.howto.linesh.tw
b3a50bd
EthanLin-TWer added a commit that referenced this issue Jan 14, 2017
@EthanLin-TWer
[#3] Fix travis, change package name in cobertura in build.gradle as …
eb837f1 
…well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EthanLin-TWer EthanLin-TWer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EthanLin-TWer