Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Remove "bindings" local dependency to fix crates.io publishing #5

Closed
wants to merge 0 commits into from

Conversation

EstebanBorai
Copy link
Owner

@EstebanBorai EstebanBorai commented Jun 19, 2021

When running "cargo publish --dry-run" an error is reported due to the
lack of the "bindings" crate in the package registry.

error: all dependencies must have a version specified when publishing.
dependency `bindings` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.

Refer to: rust-lang/cargo#7237

@EstebanBorai EstebanBorai force-pushed the fix/bindings-dependency branch from 421554e to 1426dcf Compare June 19, 2021 04:27
@EstebanBorai EstebanBorai deleted the fix/bindings-dependency branch June 19, 2021 05:02
@EstebanBorai
Copy link
Owner Author

This is attempt number 1 to fix:

    In order to publish local-ip-address with windows support we rely
    on using windows::include_bindings! macro.

    Given that any crate published should only have dependencies which
    are other crates on the same package registry (crates.io) we should
    publish a separated crate for this bindings to be available.

    Refer: https://github.com/microsoft/windows-rs/issues/819
    Refer: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-path-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant