Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish IOP code base #24

Merged
merged 8 commits into from
May 20, 2022
Merged

polish IOP code base #24

merged 8 commits into from
May 20, 2022

Conversation

zhenfeizhang
Copy link
Contributor

No description provided.

@zhenfeizhang zhenfeizhang self-assigned this May 18, 2022
@zhenfeizhang zhenfeizhang marked this pull request as ready for review May 18, 2022 20:57
Copy link
Collaborator

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @zhenfeizhang , generally LGTM

poly-iop/src/sum_check/prover.rs Outdated Show resolved Hide resolved
poly-iop/src/sum_check/prover.rs Outdated Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Outdated Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Outdated Show resolved Hide resolved
chancharles92
chancharles92 previously approved these changes May 20, 2022
@chancharles92 chancharles92 self-requested a review May 20, 2022 15:52
@chancharles92
Copy link
Collaborator

Hi @zhenfeizhang can you resolve the conflict and fix the typo here? I'll approve it again.
2ad9f5c#diff-d2a1b021a0426b2028bd5995888a71f587c6fb0d989f9cb755ab4aa172cd7925R68

@zhenfeizhang zhenfeizhang merged commit 97a89d7 into main May 20, 2022
@zhenfeizhang zhenfeizhang deleted the polish-iop-code branch May 20, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants