Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl zero check #15

Merged
merged 10 commits into from
May 16, 2022
Merged

impl zero check #15

merged 10 commits into from
May 16, 2022

Conversation

zhenfeizhang
Copy link
Contributor

No description provided.

@zhenfeizhang zhenfeizhang self-assigned this May 13, 2022
@zhenfeizhang zhenfeizhang linked an issue May 13, 2022 that may be closed by this pull request
implement zero checks #8
Closed
@zhenfeizhang
Copy link
Contributor Author

hmmm something is wrong with the CI -- the tests failed but CI shows a pass

@zhenfeizhang zhenfeizhang marked this pull request as ready for review May 13, 2022 21:10
@zhenfeizhang
Copy link
Contributor Author

tests passes ;-)

This code can use some improvement at quite a few places -- the TODOs are likely to be done via separate PRs.
In the meantime, @chancharles92 thanks for the help and would appreciate an review.

@zhenfeizhang
Copy link
Contributor Author

hmmm something is wrong with the CI -- the tests failed but CI shows a pass

it is also quite wired that my cargo-clippy did not pick up anything that CI reported.

@zhenfeizhang zhenfeizhang changed the title zero check skeleton raw impl of zero check May 13, 2022
chancharles92
chancharles92 requested changes May 14, 2022
View reviewed changes
poly-iop/src/structs.rs Outdated Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Outdated Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Outdated Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Outdated Show resolved Hide resolved
poly-iop/src/virtual_poly.rs Outdated Show resolved Hide resolved
poly-iop/src/zero_check/mod.rs Outdated Show resolved Hide resolved
poly-iop/src/zero_check/mod.rs Show resolved Hide resolved
poly-iop/src/zero_check/mod.rs Outdated Show resolved Hide resolved
poly-iop/src/zero_check/mod.rs Show resolved Hide resolved
@zhenfeizhang zhenfeizhang changed the title raw impl of zero check impl zero check May 16, 2022
@zhenfeizhang zhenfeizhang merged commit 0d77c3a into main May 16, 2022
@zhenfeizhang zhenfeizhang deleted the 8-implement-zero-checks branch May 16, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancharles92 chancharles92 chancharles92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement zero checks
2 participants
@zhenfeizhang @chancharles92