Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print: several assorted fixes/improvements. #43

Merged
merged 5 commits into from
Jul 24, 2023
Merged

print: several assorted fixes/improvements. #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df682b5
print/pretty: allow hovering over multiversion table cells to disable…
eddyb Jul 23, 2023
1ee7ea1
print: escape anchors using (HTML entities) `{` syntax.
eddyb Jul 23, 2023
7d6bae2
printf: use the new "named arguments" style for `module.{dialect,debu…
eddyb Jul 24, 2023
acbc771
print: centralize string literal printing, and improve escaping/multi…
eddyb Jul 24, 2023
d843bd6
Update CHANGELOG.
eddyb Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e
# HACK(eddyb) `sed -E -z` expression to remove parts of the SPIR-T pretty-printing
# output that we don't want to be actaully shown in an example (in `README.md`).
spirt_cleanup_sed="\
s/module\.(dialect|debug_info) = SPIR-V \{\n( [^\n]*\n)*\}\n\n//g;\
s/module\.(dialect|debug_info) = spv\.Module(\.DebugInfo)?\(.*\)\n\n//g;\
s/\nexport \{\n( [^\n]*\n)*\}//\
"

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased] - ReleaseDate

### Changed 🛠
- [PR#43](https://github.com/EmbarkStudios/spirt/pull/43) tweaked several pretty-printing
details to improve visual cohesion ("named arguments" in `module.{dialect,debuginfo}`)
and ergonomics (multi-line string literals, HTML entities for anchor escaping,
hover on multi-version table cells to disable "no changes" desaturation/dimming)
- [PR#36](https://github.com/EmbarkStudios/spirt/pull/36) started using `OpName`s
in pretty-printing, to replace the `T1`/`F2`/`v3` "anonymous" style, when unambiguous
- [PR#40](https://github.com/EmbarkStudios/spirt/pull/40) increased the pretty-printed
Expand Down
Loading