Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fn/closure #[spirv(unroll_loops)] attribute. #946

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Nov 24, 2022

This attribute was pretty hacky, as it affected all loops in the function body, because MIR is a control-flow graph so we can't see "loop expressions" to get attributes from (see below for how we could rectify that!).

To quote the CHANGELOG entry:

  • Removed the fn/closure #[spirv(unroll_loops)] attribute, as it has no users,
    is becoming non-trivial to support, and requires redesign for better ergonomics
    (e.g. #[spirv(unroll)] applied to individual loops, not the whole fn/closure)

For more context, see:

@eddyb eddyb requested a review from oisyn as a code owner November 24, 2022 16:02
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@oisyn oisyn enabled auto-merge (rebase) November 28, 2022 10:45
@eddyb eddyb requested a review from oisyn November 28, 2022 15:05
@oisyn oisyn merged commit 6eebe6c into EmbarkStudios:main Nov 28, 2022
@eddyb eddyb deleted the remove-unroll-loops branch November 28, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants