Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when inline(never) is not respected #875

Merged
merged 3 commits into from
May 24, 2022

Conversation

molikto
Copy link
Contributor

@molikto molikto commented May 17, 2022

No description provided.

@molikto molikto requested a review from eddyb as a code owner May 17, 2022 02:54
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only had nits about Rust formatting and the warning phrasing (most importantly I think we should say #[inline(never)] since that's what would be in the source code).

crates/rustc_codegen_spirv/src/linker/inline.rs Outdated Show resolved Hide resolved
@eddyb eddyb added the s: waiting on author PRs that blocked on the author implementing feedback. label May 21, 2022
@eddyb eddyb self-assigned this May 21, 2022
Comment on lines 1 to 6
warning: function `nested_ref::deep_load` has `dont_inline` attribute, but need to be inlined because it has illegal argument or return types

warning: function `nested_ref::deep_transpose` has `dont_inline` attribute, but need to be inlined because it has illegal argument or return types

warning: 2 warnings emitted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to git pull the new commit locally then run cargo compiletest --bless again to update this .stderr file.

@eddyb eddyb enabled auto-merge (rebase) May 24, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: waiting on author PRs that blocked on the author implementing feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants