Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to treat warnings as errors #683

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Add option to treat warnings as errors #683

merged 1 commit into from
Jun 22, 2021

Conversation

khyperia
Copy link
Contributor

Fixes #682

@khyperia khyperia requested a review from eddyb as a code owner June 22, 2021 13:07
@khyperia khyperia requested a review from VZout June 22, 2021 13:07
VZout
VZout approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@VZout VZout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@khyperia khyperia enabled auto-merge (squash) June 22, 2021 13:08
@khyperia khyperia merged commit 428824b into main Jun 22, 2021
@khyperia khyperia deleted the werror branch June 22, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VZout VZout VZout approved these changes

@eddyb eddyb Awaiting requested review from eddyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to treat errors as warnings through the spirv-builder.
2 participants
@khyperia @VZout