Invert glam dependency #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed a couple weeks ago in the rust-gpu weekly meeting, invert the glam dependency back to spirv-std depending on glam.
Going forward, we'll want to keep spirv-std completely agnostic other than specifically these trait impls, so it stays a fully generic library. The trait impls are also behind a feature flag, so someone can swap out glam for another vector library and not even compile glam at all (although they'll have to either impl the traits in that vector library and make it depend on spirv-std, or submit a PR adding another set of trait impls behind a feature flag like glam is here)
The complementary PR to glam is here bitshifter/glam-rs#189 but thankfully, we don't need to wait for that to go through and get into a glam release, since we can simply remove the
spirv-stdfeature flag of glam and cargo is happy with that.