Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for using target-features for extensions and capabilities #610

Merged
merged 1 commit into from
May 3, 2021
Merged

Add support for using target-features for extensions and capabilities #610

merged 1 commit into from
May 3, 2021

Conversation

XAMPPRocky
Copy link
Member

resolves #555

@XAMPPRocky XAMPPRocky requested review from eddyb and khyperia April 30, 2021 10:18
khyperia
khyperia approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@khyperia khyperia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to nuke both capability_computation.rs and the default Int8 and friends capabilities, but that can be done in a follow-up. Also, there's a couple asm!("OpCapability") in spirv-std that need to be removed (and replaced with #[cfg])

tests/ui/dis/target_features_err.rs Outdated Show resolved Hide resolved
@XAMPPRocky XAMPPRocky force-pushed the target-features branch 2 times, most recently from c7c0f6f to 2d72c25 Compare April 30, 2021 13:21
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) May 3, 2021 10:40
@XAMPPRocky XAMPPRocky merged commit 2f451ee into main May 3, 2021
@XAMPPRocky XAMPPRocky deleted the target-features branch May 3, 2021 11:19
XAMPPRocky added a commit that referenced this pull request May 3, 2021
@XAMPPRocky
Add support for using target-features for extensions and capabilities (…
590d97d 
…#610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khyperia khyperia khyperia approved these changes

@eddyb eddyb Awaiting requested review from eddyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use target features for capabilities
2 participants
@XAMPPRocky @khyperia