-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SPV_KHR_ray_query #572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
force-pushed
the
ray-query-khr
branch
7 times, most recently
from
April 1, 2021 11:15
68e1cfe
to
bc58064
Compare
XAMPPRocky
force-pushed
the
ray-query-khr
branch
15 times, most recently
from
April 16, 2021 05:56
e3e96f2
to
6318675
Compare
XAMPPRocky
force-pushed
the
ray-query-khr
branch
3 times, most recently
from
April 20, 2021 07:44
b86d1e9
to
8402531
Compare
eddyb
suggested changes
Apr 20, 2021
XAMPPRocky
force-pushed
the
ray-query-khr
branch
from
April 20, 2021 12:12
8402531
to
45a69a2
Compare
eddyb
suggested changes
Apr 20, 2021
XAMPPRocky
force-pushed
the
ray-query-khr
branch
from
April 27, 2021 11:31
a3dcb87
to
d6c0480
Compare
eddyb
suggested changes
Apr 27, 2021
XAMPPRocky
force-pushed
the
ray-query-khr
branch
from
April 27, 2021 12:04
d6c0480
to
7956e8a
Compare
XAMPPRocky
force-pushed
the
ray-query-khr
branch
from
April 27, 2021 12:07
7956e8a
to
37e32d8
Compare
eddyb
suggested changes
Apr 27, 2021
XAMPPRocky
force-pushed
the
ray-query-khr
branch
from
April 27, 2021 12:24
37e32d8
to
2f9a2b0
Compare
eddyb
approved these changes
Apr 27, 2021
XAMPPRocky
force-pushed
the
ray-query-khr
branch
from
April 27, 2021 12:37
2f9a2b0
to
852a580
Compare
eddyb
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for
SPV_KHR_ray_query
in rust-gpu. The only current exception isOpRayQueryGetIntersectionObjectToWorldKHR
andOpRayQueryGetIntersectionWorldToObjectKHR
, because we don't have aMatrix
trait yet, and I wanted to think about how that would work more.Depends on #563 since it needs
AccelerationStructure
for some functions.cc @hrydgard @repi