Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lang_items into spirv-std #275

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Move lang_items into spirv-std #275

merged 1 commit into from
Nov 26, 2020

Conversation

XAMPPRocky
Copy link
Member

This PR moves the lang_items that shader crates need to define into spirv-std itself, so spirv-std behaves a little more like std, and reduces the amount of code you need to get started. It's included under a default feature so if for some reason you still need to define your own lang_items you still can.

@XAMPPRocky XAMPPRocky requested a review from khyperia November 26, 2020 08:47
@XAMPPRocky XAMPPRocky added the s: waiting on review PRs that blocked on a team member's review. label Nov 26, 2020
khyperia
khyperia approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@khyperia khyperia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! last time I tried doing this there were absolutely garbage build issues and I gave up, but if it somehow magically works now, 🎉

@mergify mergify bot merged commit 59869ec into main Nov 26, 2020
@mergify mergify bot deleted the include-lang-items branch November 26, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khyperia khyperia khyperia approved these changes

Assignees
No one assigned
Labels
s: waiting on review PRs that blocked on a team member's review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XAMPPRocky @khyperia