rustup: update to nightly-2023-07-08.
#1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worst part about this was the convoluted way I've made
const_data_from_allocdefer getting the actual type to interpret the data as (ideally it would generate SPIR-V that is only valid inKernelmode, but onlyqptrstands a chance to make that work, and even none of my experimental branches do global initializers).My hack in this PR appears to work, but it would be nice to get rid of it in another release or two (and in general rely less and less on pointer types from
rustc_codegen_ssa- it's more of a coincidence that we get that information at all! in particular, LLVM's opaque pointer types are only recently becoming mandatory)