entry: apply NonWritable
to read-only StorageBuffer
s.
#1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
NonWritable
to#[spirv(storage_buffer)] x: &T
(ifT
doesn't have interior mutability).NonReadable
)(also we should maybe do something different for storage images?)
StorageBuffer
as, according tospirv-val
, only it andUniform
allowNonWritable
, andUniform
buffers are always read-only anywaywgpu
read-only-storage
buffers are stricter than their Vulkan counterparts)