Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup commands on plugin unload #157

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Cleanup commands on plugin unload #157

merged 1 commit into from
Jun 18, 2018

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented May 4, 2018

Fixes #123. Possible better solution than #144.

Thank you @tpope and others for explaining the issue and fix.

Tested on macOS 10.13.4 with Vim (8.0.1750) and Neovim (0.2.2).

@mdxprograms
Copy link
Contributor

@jesse-c I think this is definitely a cleaner fix than my previous one! Would you mind removing my additional exclamations on master branch if you haven't already and adding to your changes to make sure my additions don't conflict? Not sure they would or if my changes could have more potential for issues down the road, but if they aren't needed by adding your fix I'd rather remove what I had in there in this PR while submitting your fix. Nice work btw

@jesse-c
Copy link
Contributor Author

jesse-c commented Jun 18, 2018

@mdxprograms my understanding from what tpope and the others were saying is that your changes shouldn't be necessary. I've updated the branch to revert them :) And thanks! But all credit goes to the others pointing out the solution, I just did the implementation

@mdxprograms
Copy link
Contributor

lgtm

@mdxprograms mdxprograms merged commit e51e2e4 into ElmCast:master Jun 18, 2018
@jesse-c jesse-c deleted the cleanup-commands branch June 18, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command already exists, append ! to replace it
2 participants