Ros2 launch #25
Merged
Ros2 launch #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launch files need to end with _launch or .launch to be install by colcon.
remove additional creation of another second src folder
|
@fllay can you please test the changes on ROS2 stack? Then I could mention you as a reviewer |
|
I will test it this weekend
…On Mon, 8 May 2023 at 20:01 Andrei Vukolov ***@***.***> wrote:
@fllay <https://github.com/fllay> can you please test the changes on ROS2
stack? Then I could mention you as a reviewer
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6HLGYOUKHHNOQSMIBZJ6DXFDVCZANCNFSM6AAAAAAXZNU2JA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@fllay thank you! Looking forward to seeing the test report from you! |
|
I tested with WT61C. It seems to be OK. |
|
@fllay thanks, so I consider this PR to merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im using the wit imu in ros2 humbel and the launch file could only be recognized if I renamed them to end with _launch or .launch