Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wechat support #278

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add wechat support #278

wants to merge 7 commits into from

Conversation

yunhaia
Copy link

@yunhaia yunhaia commented Jan 7, 2015

add wechat support

@yunhaia
Copy link
Author

yunhaia commented Jan 31, 2015

img_5556
share to wechat

@ghost
Copy link

ghost commented Mar 11, 2015

+1 to this

@Alir3z4
Copy link

Alir3z4 commented Apr 27, 2015

👍

2 similar comments
@wozzup
Copy link

wozzup commented May 7, 2015

+1

@bau720123
Copy link

+1

@pluswave
Copy link

why this pull request is rejected to merge ? I have created a updated version here: https://github.com/pluswave/SocialSharing-PhoneGap-Plugin for latest master and fix some issues and add title support, should I create a new pull request ?

@rayshan
Copy link

rayshan commented Feb 3, 2016

@pluswave I don't think this PR is rejected, the maintainers just haven't gotten around to reviewing it.

👍 too btw

@EddyVerbruggen
Copy link
Owner

My main issue with this is that this plugin doesn't embed any native SDK's. Wechat would be the first and the plugin jumps from 0,9KB to 7,3MB. If I'd add all native SDK's you can imagine what would happen.

Perhaps a sep wechat plugin would make more sense. Curious to learn what you guys think, although you're a bit biased I guess ;)

But I'll give it some thought since there's high demand. Can you submit a PR as this one can no longer be merged (or an update to this one is fine as well of course).

@grapemix
Copy link

We really want to this plugin can support sharing to wechat, even with plugin or whatever method. At least an image and url can be shared. Thanks a lot for the hard working for this plugin.

@zhouhao27
Copy link

Great! Is it merged to the main branch already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants