Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Create chidubem.json profile page #1934

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Create chidubem.json profile page #1934

merged 1 commit into from
Oct 10, 2022

Conversation

Duks31
Copy link
Contributor

@Duks31 Duks31 commented Oct 9, 2022 •
edited
Loading

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

github-actions[bot]
github-actions bot reviewed Oct 9, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Welcome @Duks31! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions labels Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest.

@Duks31
Copy link
Contributor Author

Duks31 commented Oct 9, 2022

Happy to Join the community
My first opensource PR :)

Panquesito7
Panquesito7 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🎉

accodes21
accodes21 suggested changes Oct 9, 2022
View reviewed changes
Copy link
Member

@accodes21 accodes21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.
Everything looks good but just change the small typo at icon : LinkedIn

@Duks31
Copy link
Contributor Author

Duks31 commented Oct 9, 2022

Thanks
Changing that right away

@Duks31
Copy link
Contributor Author

Duks31 commented Oct 9, 2022

Sorry,
I am having a problem, I cant see my file ( chidubem.json ) in either my fork or in the EddieHub fork

I dont know what is wrong

@Panquesito7
Copy link
Member

Sorry, I am having a problem, I cant see my file ( chidubem.json ) in either my fork or in the EddieHub fork

I dont know what is wrong

Try checking the Duks-patch-1 branch https://github.com/Duks31/LinkFree/tree/Duks31-patch-1

@Duks31
Copy link
Contributor Author

Duks31 commented Oct 9, 2022

OK
Thanks, I found it 👍

But it hasnt been merged to EddieHubCommunity

@Panquesito7
Copy link
Member

OK Thanks, I found it 👍

But it hasnt been merged to EddieHubCommunity

If you want to update this PR, it doesn't have to be merged.

@Duks31
Copy link
Contributor Author

Duks31 commented Oct 9, 2022

OK Thanks

But the LinkFree webite doesnt have link yet, Thats why i am asking about the merging.

@Panquesito7
Copy link
Member

OK Thanks

But the LinkFree webite doesnt have link yet, Thats why i am asking about the merging.

Hmm, what do you mean? 🤔

@Duks31
Copy link
Contributor Author

Duks31 commented Oct 9, 2022

I addem my json file chidubem.json to the LinkFree/public/data folder,

According to the instructions which i followed up to this point i have made a PR and it has been approved so i am waiting for the merge

kumarsonsoff3
kumarsonsoff3 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit e3ffbc7 into EddieHubCommunity:main Oct 10, 2022
@Duks31
Copy link
Contributor Author

Duks31 commented Oct 10, 2022

Thanks for the Merge 🤩

@gptkrsh gptkrsh mentioned this pull request May 9, 2024
Open
@gptkrsh gptkrsh mentioned this pull request May 23, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@accodes21 accodes21 accodes21 requested changes

@kumarsonsoff3 kumarsonsoff3 kumarsonsoff3 approved these changes

@AryanBabber AryanBabber AryanBabber approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions medium Pull request with changed lines between 10 and 30
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Duks31 @Panquesito7 @AryanBabber @kumarsonsoff3 @accodes21