-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynRPG whitelist + easyrpg_raw command #3137
base: master
Are you sure you want to change the base?
Conversation
24cdc27
to
3ba6522
Compare
btw that "frame pushing" looks like a safe solution for this |
https://jetrotal.github.io/CSA/#MNC%20|%20Call%20Command It's similar but uses an array of variables in sequence for the arguments |
That PR is kinda the wrong location for this, so one final question before we move this maybe somewhere else: I think that CSA example needs more permutations and a 3rd argument to figure out how this works. E.g.
|
@Ghabry I also set up a collection of useful constants, that came from destinyScript. Those could be useful for parsing common values: made in two formats, the second one is a Map, I guess that's the one that would work with current code: copy the text at the bottom of the page. |
d2be8f8
to
5fd9447
Compare
5660b7f
to
1b99aff
Compare
Hey guys, I removed a lot of repeated code, and included some functions we already have in Utils. I think this is good enough for a working raw command interpreter. Other things that may be important for this in the future is setting up the "constants.h" content as As soon as this this pr is aproved, I can rework #3124 as you guys asked. |
f54cba9
to
b1da06d
Compare
b1da06d
to
9d0e41b
Compare
I talked with Jetrotal: I will help getting this in when I'm done with my remaining issues for 0.8.1 milestone. Likely in one or two weeks. My current plan is to split it into two PRs. One for the DynRPG refactor, one for easyrpg_raw. Makes reviewing this a bit easier :) |
9d0e41b
to
fcd862e
Compare
Would you mind when I swap the argument order to:
Makes "indent" the 2nd parameter and the numeric list everything from 3rd to the end. Makes the parsing simpler and is not ambigious. |
hm... I made it this way to let people ignore the indent parameter, and read each type of parameter by group |
@Ghabry asked for me to post the event2string command I was working on, here it is: |
fcd862e
to
d5f00c3
Compare
d7907e4
to
47940ef
Compare
whitelisting easyRPG commands so they can be called even when dynRPG is off.
Invoke a command using raw values, similar to how maniacs patch raw work. NOTE FIXME PLS.
This makes cleanup of state easier when switching between games.
@easyrpg_raw @ShowMessage, "This is new"
implementation is a bit ugly, need help to clear this
removed repeated code, and overcomplex logic.
Managed to make it work, but the code is a bit messy and its syntax is not very flexible;
Store commands inside a Stringvariable. //$storeCommands "preffix",[evtType_isVar, evtType, evtId_isVar, evtId, evtPage_isVar, evtPage, targetStrVar_isVar, targetStrVar] // 2099, "@easyrpg_raw", [1,4, 1,5, 1,6, 1,7], 0;
now, our raw code also use this library.
1f14c42
to
04ca1ba
Compare
Whitelist selected dynRPG commands, so people can use them without enabling the dynRPG plugin.
Invoke a command using raw input, similar to how maniacs patch raw work.
easyRPG raw syntax: