Various fixes #2913
Merged
Various fixes #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command Fix ä2695
…e used Fixes the battles in Mother: Cognitive Dissonance which uses fancy background effects Fix EasyRPG#2893
Fixes the game "Despoina" when "Blind Strike" is used. Fix EasyRPG#2896
Wrong variable was checked Fix EasyRPG#2899
There is one warning left in "platform.cpp" about GetEntryType(...) where I'm not sure how to solve it. Removing it breaks the build on platforms that do not provide d_type.
Because this is just an intermediate library it avoids unnecessary linking
Not sure how this is possible but I received a savegame with this issue. RPG_RT has no problems with this and fixes them.
fdelapena
approved these changes
Mar 10, 2023
21.08 lacks sdl2main.a and the sdl2-config requires it Our find module works without it
Otherwise it crashes because the window buffer is too small
Shift-Jis can have bytes that map to \, corrupting the sequence Fix EasyRPG#2907
…ow is too small Resolve some stringpic related warnings Fix EasyRPG#2920
Ghabry
commented
Mar 14, 2023
There was a problem hiding this comment.
testing new github review feature: File comments (instead of line comments)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Do not merge yet, in case there are more simple one-liners :))Fix #2695