-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Android build to gradle+CMake #2475
Conversation
To build set EASYRPG_TOOLCHAIN_DIR and EASYRPG_LIBLCF_DIR to the paths that contain all the Android toolchains. Then run "gradle assembleRelease" and the magic happens. Fix EasyRPG#621
Dont merge this yet. |
…ONE;PATH_TWO;PATH_THREE" instead of an env var Additional CMake arguments are possible with -PcmakeOptions or env var ORG_GRADLE_PROJECT_cmakeOptions
CMake options are now possible with -PcmakeOptions="-DOPTION1=ON OPTION2=OFF" or env var ORG_GRADLE_PROJECT_cmakeOptions="-DOPTION1=ON OPTION2=OFF" (the env var is a built-in gradle feature) |
…radle.properties file
@@ -0,0 +1,15 @@ | |||
cmake_minimum_required(VERSION 3.7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just thinking we could add this to the main CMakeLists as well.
However, it is currently really convoluted, so maybe we should split other things out like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo it would make sense to move all the system dependent stuff in CmakeLists.txt in the build/ folder. Currently the main file is quite messy.
When devkitXXX and VitaSDK are ever built through CMake we could hide all the custom stuff (build_vpk, make_dol, etc.) in subfolders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When devkitXXX and VitaSDK are ever built through CMake we could hide all the custom stuff (build_vpk, make_dol, etc.) in subfolders.
of course!
@@ -1,3 +1,8 @@ | |||
android.enableJetifier=true | |||
android.useAndroidX=true | |||
android.useDeprecatedNdk=true | |||
|
|||
VERSION_NAME=1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should start to set these with each release from now on.
This way f-droid will have it easier at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works 👍🏼
To build set env var EASYRPG_TOOLCHAIN_DIRS to the paths that contain all the Android toolchains.
Then run "gradle assembleRelease" and the magic happens.
Fix #621