CMake: Install bash-completion and add man and doxygen status message #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rts this later Add status output
Unconditionally on Unix as bash is usually available there. On other platforms depend on bash-completion package as a hint. Fix EasyRPG#2396
Ghabry
force-pushed
the
cmake-install-bashcomp
branch
from
7be5abf to
41c6783
Compare
|
For Windows and macOS I get: Which is good. Local I get Emscripten gives (emscripten is always special because it is not considered crosscompiling) @akien-mga |
|
The patch works well for me (applied on top of 0.6.2.3) 👍 |
fdelapena
approved these changes
Oct 12, 2020
fmatthew5876
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoded the completion dir to "${CMAKE_INSTALL_DATADIR}/bash-completion/completions" as suggested in #2396 otherwise this is a mess because the one returned by bash is an absolute directory which makes "install" fail without sudo...
For Unix I always install it, for all other platforms I depend on bash-completion being installed. This way one can also get the completion on Msys2 or macOS if this makes any sense ^^