-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend external CI to support non-github repos #399
Conversation
6103f69
to
e8dad30
Compare
This is going to be a lot more work than I hoped... (Of course it had to be.) |
Shelving this for now, given that |
e8dad30
to
9879a57
Compare
Rebased to check if this still works with non-nix based external CI scripts. |
I think that we should run the external project in weak check mode (we cannot really afford doing a full check at each commit) + a full check on a regular basis. |
This requires the runtest command to be able to take any option of the |
And I need to extend things further to make sure we check the right branch. (This is to allow external proofs to have both a branch that runs with the latest stable and a branch that keeps up to date (with or without lag) with easycrypt's HEAD.) |
978edb9
to
ff83ebf
Compare
ff83ebf
to
6742013
Compare
583b4c7
to
2f82d97
Compare
2f82d97
to
ffe7c0e
Compare
Co-authored-by: Pierre-Yves Strub <[email protected]>
Proofs are checked in weak-mode. Co-authored-by: Pierre-Yves Strub <[email protected]>
ffe7c0e
to
37ccc35
Compare
This adds support for external proof repos hosted off github to the existing (simple) external CI infrastructure, and uses SHA3 as a CI test.
The immediate ambition is to add all external proofs that should check with
main
(XSalsa, CryptoBox, XMSS, ...) to checks for PRs ontomain
(not for arbitrary commits; the restriction still needs added). This will then enable the developers of feature branches (deploy-expected-cost
,deploy-qrom
) to activate external CI for the external proofs they support.