Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend external CI to support non-github repos #399

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

fdupress
Copy link
Member

This adds support for external proof repos hosted off github to the existing (simple) external CI infrastructure, and uses SHA3 as a CI test.

The immediate ambition is to add all external proofs that should check with main (XSalsa, CryptoBox, XMSS, ...) to checks for PRs onto main (not for arbitrary commits; the restriction still needs added). This will then enable the developers of feature branches (deploy-expected-cost, deploy-qrom) to activate external CI for the external proofs they support.

@fdupress fdupress added the chore Ungrateful tasks that need done but that nobody wants to do label Jun 16, 2023
@fdupress fdupress requested a review from strub June 16, 2023 16:29
@fdupress fdupress self-assigned this Jun 16, 2023
@fdupress fdupress force-pushed the extend-external-ci branch 3 times, most recently from 6103f69 to e8dad30 Compare June 16, 2023 16:51
@fdupress
Copy link
Member Author

checks for PRs onto main (not for arbitrary commits; the restriction still needs added).

This is going to be a lot more work than I hoped... (Of course it had to be.)
We will need to split the workflow out into another workflow file. This requires a whole lot of additional fiddling if we want to keep the condition on successful compilation, and perhaps successful checking of stdlib, and if we want to avoid multiplying job notifications.

@fdupress fdupress marked this pull request as draft November 21, 2023 10:14
@fdupress
Copy link
Member Author

Shelving this for now, given that nix does not seem to provide as stable a CI environment as we'd hoped.

@fdupress fdupress force-pushed the extend-external-ci branch from e8dad30 to 9879a57 Compare April 5, 2024 12:42
@fdupress
Copy link
Member Author

fdupress commented Apr 5, 2024

Rebased to check if this still works with non-nix based external CI scripts.
This would still require a bit of work (as far as I understand) to make sure the external CI jobs only run on PRs onto main (while also retaining the standard checks on PRs).

@strub
Copy link
Member

strub commented Apr 5, 2024

I think that we should run the external project in weak check mode (we cannot really afford doing a full check at each commit) + a full check on a regular basis.

@strub
Copy link
Member

strub commented Apr 5, 2024

This requires the runtest command to be able to take any option of the provers group. There is an issue for that.

@fdupress
Copy link
Member Author

fdupress commented Apr 5, 2024

And I need to extend things further to make sure we check the right branch. (This is to allow external proofs to have both a branch that runs with the latest stable and a branch that keeps up to date (with or without lag) with easycrypt's HEAD.)

@strub
Copy link
Member

strub commented Apr 7, 2024

See #506 & #531

@strub strub force-pushed the extend-external-ci branch 2 times, most recently from 978edb9 to ff83ebf Compare April 8, 2024 13:41
@strub strub marked this pull request as ready for review April 8, 2024 13:42
@strub strub force-pushed the extend-external-ci branch from ff83ebf to 6742013 Compare April 8, 2024 13:46
@strub strub force-pushed the extend-external-ci branch 3 times, most recently from 583b4c7 to 2f82d97 Compare April 12, 2024 12:34
@strub strub force-pushed the extend-external-ci branch from 2f82d97 to ffe7c0e Compare April 12, 2024 12:35
fdupress and others added 2 commits April 12, 2024 14:36
Proofs are checked in weak-mode.

Co-authored-by: Pierre-Yves Strub <[email protected]>
@strub strub force-pushed the extend-external-ci branch from ffe7c0e to 37ccc35 Compare April 12, 2024 12:37
@strub strub merged commit 9fa531e into main Apr 12, 2024
17 checks passed
@strub strub deleted the extend-external-ci branch April 12, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Ungrateful tasks that need done but that nobody wants to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants