This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add command line option --snapshot-to-json 📦 #11058
Open
heifner
wants to merge
2
commits into
develop-boxed
Choose a base branch
from
EPE-2071-snapshot-to-json
base: develop-boxed
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
Add command line option --snapshot-to-json
Add command line option --snapshot-to-json 📦
Feb 2, 2022
I wonder how long this takes to run on a wax snapshot? They're huge. I can't imagine the json file. |
1hr to read WAX 21GB binary snapshot, 37 minutes to write the 59 GB JSON on my old mac. |
linhuang-blockone
approved these changes
Feb 7, 2022
dimas1185
reviewed
Mar 17, 2022
@@ -963,6 +965,57 @@ void chain_plugin::plugin_initialize(const variables_map& options) { | |||
EOS_THROW( extract_genesis_state_exception, "extracted genesis state from blocks.log" ); | |||
} | |||
|
|||
std::optional<chain_id_type> chain_id; | |||
if( options.count("snapshot-to-json") ) { | |||
my->snapshot_path = options.at( "snapshot-to-json" ).as<bfs::path>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move that code to the separate method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
--snapshot-to-json
which reads given snapshot.bin and generates a JSON equivalent file.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions