Set sequence number in msg_heartbeat, which is sent to drone

[snorkel123]

Closes #578

[PaulLoizeaux]

@alextel69 This is only being set in msg_heartbeat as you said. Shouldn't the correct sequence number be set in every message that is sent?

[snorkel123]

@PaulLoizeaux thanks for your note, I really forgot to fix other messages. Do all packets need to have same seq number or they may have individual ones?

[PaulLoizeaux]

@alextel69 I think the sequence number of each packet should be sequential regardless of what type of message it is. It is a way to tell if it lost any packets in transit I think.

The problem I think we have at that point is that we need to find every place that sends a MAVLink message so we can implement a sequence number in them.

[arthurbenemann]

Or just maintain the sequence state on the mavconnection class, and
overwrite the seq field in the packets as required.
On Aug 19, 2014 5:29 PM, "Paul Loizeaux" [email protected] wrote:

@alextel69 https://github.com/alextel69 I think the sequence number of
each packet should be sequential regardless of what type of message it is.
It is a way to tell if it lost any packets in transit I think.

The problem I think we have at that point is that we need to find every
place that sends a MAVLink message so we can implement a sequence number in
them.

—
Reply to this email directly or view it on GitHub
#956 (comment)
.

[snorkel123]

@arthurbenemann every sent packet should have i+1 seq number?

[arthurbenemann]

@alextel69 yes, warping around at 255. The best place to do it is probably here, right before encoding the packet into a byte array

[arthurbenemann]

@alextel69 Ready for a merge?

[snorkel123]

@arthurbenemann could you take a look at last commit - I am unsure whether I understood "rolling" correctly.
If it is ok, than ready for merge

[arthurbenemann]

Looks correct. The correct term is integer overflow

[snorkel123]

Glad to hear it from you!
It also modifies .gitignore, just be aware of it.

[arthurbenemann]

@alextel69 Don't worry, I try to review every line that is merged :)