Fixes issue #852 #853
Merged
Fixes issue #852 #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
m4gr3d
commented
Jul 3, 2014
m4gr3d
commented
- fixes issue Null Pointer Exception #852 by making sure the map is initialized before any interaction with it.
- adds omitted art resource file.
…fore any interaction with it.
| @@ -82,6 +83,10 @@ public View onCreateView(LayoutInflater inflater, ViewGroup viewGroup, | |||
| @Override | |||
| public void onStart(){ | |||
| super.onStart(); | |||
|
|
|||
| //Make sure the map is initialized | |||
| MapsInitializer.initialize(getActivity().getApplicationContext()); | |||
There was a problem hiding this comment.
Does it change anything for normal operation?
There was a problem hiding this comment.
No, if the map is already initialized, then the call is a no-op operation.
- Fredia Huya-Kouadio
https://github.com/ne0fhyk
https://bitbucket.org/ne0fhyk
On Thu, Jul 3, 2014 at 1:20 AM, Arthur Benemann [email protected]
wrote:
In
Android/src/org/droidplanner/android/maps/providers/google_map/GoogleMapFragment.java:@@ -82,6 +83,10 @@ public View onCreateView(LayoutInflater inflater, ViewGroup viewGroup,
@OverRide
public void onStart(){
super.onStart();
+
//Make sure the map is initializedMapsInitializer.initialize(getActivity().getApplicationContext());Does it change anything for normal operation?
—
Reply to this email directly or view it on GitHub
https://github.com/DroidPlanner/droidplanner/pull/853/files#r14497285.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.