Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar notification update #851

Merged
merged 5 commits into from
Jul 3, 2014
Merged

Conversation

m4gr3d
Copy link
Member

@m4gr3d m4gr3d commented Jul 2, 2014

First phase of a set of updates to the status bar notification.
This update expands the status bar notification with the telemetry data available on the action bar.
It also adds a connect/disconnect action button that allows toggle of the drone connection from the status bar.

test

test

@arthurbenemann
Copy link
Member

Do you want me to merge it or you still have commits to do?

@m4gr3d
Copy link
Member Author

m4gr3d commented Jul 3, 2014

It's good for merging.
On Jul 2, 2014 9:43 PM, "Arthur Benemann" [email protected] wrote:

Do you want me to merge it or you still have commits to do?


Reply to this email directly or view it on GitHub
#851 (comment)
.

@@ -1,9 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" >

<!-- Contains drone related preferences, and tuning. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ne0fhyk Thanks for commenting the sections

arthurbenemann added a commit that referenced this pull request Jul 3, 2014
@arthurbenemann arthurbenemann merged commit dea5023 into master Jul 3, 2014
@arthurbenemann arthurbenemann deleted the feature_notification_update branch July 3, 2014 03:11
@arthurbenemann
Copy link
Member

@ne0fhyk for future release could you push the branches to your own fork?

I'm just trying to keep the number o branches on https://github.com/DroidPlanner/droidplanner/branches low. (I fact I'm working on merging/closing the stale branches in there)

@m4gr3d
Copy link
Member Author

m4gr3d commented Jul 3, 2014

Sure, sounds good. So as usual, pull requests from my branches onto matter?
On Jul 2, 2014 11:14 PM, "Arthur Benemann" [email protected] wrote:

@ne0fhyk https://github.com/ne0fhyk for future release could you push
the branches to your own fork?

I'm just trying to keep the number o branches on
https://github.com/DroidPlanner/droidplanner/branches low. (I fact I'm
working on merging/closing the stale branches in there)


Reply to this email directly or view it on GitHub
#851 (comment)
.

@arthurbenemann
Copy link
Member

Yes, just keep the feature branches on your fork while they are not merged. This way it's easy to not overlap on each other.

Ideally we should only have the {master, release, beta} branches on droidplanner/droidplanner.

@arthurbenemann
Copy link
Member

This is how it looks on Android L:
screenshot_2014-07-02-20-21-26
screenshot_2014-07-02-20-22-53
screenshot_2014-07-02-20-22-22
screenshot_2014-07-02-20-22-35

@m4gr3d
Copy link
Member Author

m4gr3d commented Jul 3, 2014

Sounds good.
On Jul 2, 2014 11:27 PM, "Arthur Benemann" [email protected] wrote:

Yes, just keep the feature branches on your fork while they are not
merged. This way it's easy to not overlap on each other.

Idealy we should only have the {master, release, beta} branches on
droidplanner/droidplanner.


Reply to this email directly or view it on GitHub
#851 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants