Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented optional max volume on start (Issue 375) #838

Merged
merged 3 commits into from
Jul 1, 2014

Conversation

squilter
Copy link
Member

@squilter squilter commented Jul 1, 2014

Close #375

@arthurbenemann
Copy link
Member

looks good, just merge master into it and I`ll merge it.

….git into issue_375

Conflicts:
	Android/res/values/preferences_keys.xml
@arthurbenemann arthurbenemann reopened this Jul 1, 2014
arthurbenemann added a commit that referenced this pull request Jul 1, 2014
Implemented optional max volume on start (Issue 375)
@arthurbenemann arthurbenemann merged commit ea18750 into DroidPlanner:master Jul 1, 2014
@squilter squilter deleted the issue_375 branch July 1, 2014 00:25
@m4gr3d
Copy link
Member

m4gr3d commented Jul 1, 2014

@arthurbenemann @squilter preferences access and updates should go through the DroidplannerPrefs class.

@squilter
Copy link
Member Author

squilter commented Jul 1, 2014

Oops. Will fix tomorrlw.

@arthurbenemann
Copy link
Member

@ne0fhyk Thanks for the code review. Fixed at #840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants