Fix editor tools bugs #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- saved last selected editor tool so it can be retrieved after the fragment is recreated (i.e: after orientation switch). Before the selected tool would reset to the marker tool on orientation switch. - exported commonly used code into functions. - updated the editor tools view to reflect the selected tool after orientation switch. - updated the editor activity to update the state of the tools on resume.
- updated editor activity so that reference to a displayed item detail window is retained across activity lifecycle events. Before that update, dismissing an item detail window after a lifecycle event (i.e: orientation switch) would leave the mission item in a selected state (instead of deselecting it), among other possible issues. - updated the mission detail fragment to notify its listener/parent when it's being dismissed, when shown as a dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of bugs, including crashing bugs, in the editor activity.
Changes log: