-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle support #619
Gradle support #619
Conversation
@zumbrunnen Great job! I'll try to run the project when I get off work, and see if I ran into any issues. |
Hey @ne0fhyk
|
I hope to do this merge in a couple of hours. @ne0fhyk could you check the build via gradle and post here? Ill make sure
|
Thats the way it works with google services, what we dont have is a way to |
I just tested the build on Eclipse+ADT and it build-ed without problems, so I'm merging this. Also the change to API19 is a good change. I have not confirmed that the gradle build works, but since that doesn't interfere with the eclipse build there should be no problems for other developers. @zumbrunnen Now I see why you wanted me to do the merges of the submodules before making this pull request, you needed the merge commit id (I was thinking to myself why he needs me to merge that since he has already commited the changes to his own fork). |
Please update your submodulesOn the command line run: |
@zumbrunnen sorry for the delay, i had to take care of some work. |
@ne0fhyk I encountered this error, too. It wants to tell us "you have a library twice (with two different versions) in your app". Cause for this is the Android Support library which is linked by the main project and by the projects in the submodules. If everything is the same version, you won't see this error. That's why I mentioned my concern "Different Android Support libraries". |
@zumbrunnen I got it to work. It seems that for whatever reasons I wasn't getting the latest update to the submodule even after running
with
I tested it, and the application build fine with those entries. |
Hey @ne0fhyk Do you fix the Gradle files or shall I? |
@zumbrunnen you already got the work started so it's all yours :) Also, could you try to import the project from scratch after removing the *.iml files. I think they update with local information, so it might be better to remove them from the git repository if they're not needed to successfully import the project in android studio. |
@ne0fhyk Wilco! I'll file 3 "clean up" PRs (for the main project and the 2 sub modules) as soon as I find some time. @arthurbenemann For the "clean up" it would be good to merge the 2 PRs for the submodules first, so I can include the new subproject commits in the main PR (droidplanner repo). |
@zumbrunnen The submodules pull's have been merged, fell free to proceed with #623. I'm sorry for the delay, I expĺained my reasons here |
Gasp! That gave me headaches! After a few more hours, I managed to do achieve basic Gradle support: Project can be opened and built in Android Studio. Here's what I've done:
Except for the last bullet (API update), the traditional builds with Eclipse should not be affected by this.
Anyway, there are a few things to care about in the future:
.gitignore
files aren't perfect yet. We need some more experience for a better tuning. For the moment, I excluded the whole.idea
directory.