Added support to video streaming using a UVC DEVICE + Translation to Brazilian Portuguese (PT-BR) #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Brazilian Portuguese
|
Hello, |
|
@guiseco sorry for the delay in reviewing this pr. I'll review it tonight, and add feedback as needed! |
|
@guiseco while I'm reviewing the pr, could you update the Tower wiki with instructions to setup and use video streaming via a uvc device. |
|
|
||
|
|
||
|
|
||
| public class UVCDialog extends DialogFragment { |
There was a problem hiding this comment.
@guiseco can you make use of the DialogFragment from the support library instead.
| protected var aspectRatio_4_3: Float = 3f / 4f | ||
| protected var aspectRatio_16_9: Float = 9f / 16f | ||
| protected var aspectRatio_21_9: Float = 9f / 21f | ||
| protected var aspectRatio_1_1: Float = 1f / 1f |
There was a problem hiding this comment.
@guiseco seems like the aspect ratios above should be defined as constants.
|
@ne0fhyk Could you check again ? |
|
@guiseco I'm on it! |
|
Looks good, merging! |
m4gr3d
added a commit
that referenced
this pull request
Dec 14, 2015
Added support to video streaming using a UVC DEVICE + Translation to Brazilian Portuguese (PT-BR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Feature to insert FPV on 3DR Tower.
https://goo.gl/photos/EbPe6FteiWYeEmXr9
https://goo.gl/photos/BJH7HoPE8uBnoLJo9