Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Create a button for doing a takeoff into AUTO #1115

Merged
merged 1 commit into from
Oct 2, 2014

Conversation

arthurbenemann
Copy link
Member

This button does a Guided takeoff and switches to auto in sequence.

Quoting @zlite: " It does the magic behind the button" ( If I remember that correctly)

@m4gr3d
Copy link
Member

m4gr3d commented Oct 2, 2014

@arthurbenemann this is confusing UX, as now there are two buttons that have the same icon, and text but do different things.
The better option would be to add an option in the settings for the user to select the desired mode after take off.

@arthurbenemann
Copy link
Member Author

@ne0fhyk Actually they do the same thing which is to start/continue an AUTO mission. But when you are armed and in the ground it does the takeoff (there was no way to start the auto mission from the ground if you are armed, even if you have a takeoff point at the start).

And this is much better than faking a throttle bump via RC override.

@m4gr3d
Copy link
Member

m4gr3d commented Oct 2, 2014

@arthurbenemann In that case, to be consistent, the take off button should be replaced by the guided button. Since we don't have virtual or external controllers support, the only reason to control purely from the app is via guided, or through a mission (auto).

@m4gr3d
Copy link
Member

m4gr3d commented Oct 2, 2014

@arthurbenemann actually the same logic applies to other functionality like follow-me. Right now, we require the drone to be in the air, before the functionality can be activated.
If one functionality (auto in this case) can take off from the ground, then other functionality should be able to do the same in order to remain consistent.

@arthurbenemann
Copy link
Member Author

@ne0fhyk Auto is expected to be done from the ground with an Armed copter, think of a autonomous mission. Things like follow-me it's expected of the user to be in the air. We have flown this setup and the user experience is good.

@m4gr3d
Copy link
Member

m4gr3d commented Oct 2, 2014

@arthurbenemann this assumption is incorrect. Until that feature was added, all the auto missions were done either from the air, or with direct user input (throttle bump).
And as can be seen from the google analytics, the majority of cases when the follow-me button was selected was when the drone was not in the air. So if anything, i'd argue that follow-me is a feature that's expected to be done from the ground.

@jason4short
Copy link
Contributor

This is a good point, but let's take a conservative approach for now and only add things as needed. if we put everything in logically possible we'll make it harder for users to grok.

arthurbenemann added a commit that referenced this pull request Oct 2, 2014
Android: Create a button for doing a takeoff into AUTO
@arthurbenemann arthurbenemann merged commit 85458a7 into master Oct 2, 2014
@arthurbenemann arthurbenemann deleted the AutoTakeoff branch October 2, 2014 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants