Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI cleanup! #1106

Merged
merged 9 commits into from
Oct 1, 2014
Merged

UI cleanup! #1106

merged 9 commits into from
Oct 1, 2014

Conversation

m4gr3d
Copy link
Member

@m4gr3d m4gr3d commented Oct 1, 2014

Fixed several ui related issues:

m4gr3d added a commit that referenced this pull request Oct 1, 2014
@m4gr3d m4gr3d merged commit b48c052 into DroidPlanner:master Oct 1, 2014
@m4gr3d m4gr3d deleted the fix_issue_1093 branch October 1, 2014 10:19
@arthurbenemann
Copy link
Member

Great PR @ne0fhyk.

But we might need a touch from @jason4short in here. One thing that strikes me as odd is different buttons for pre-arm and armed state. Here are some screenshots:

screenshot_2014-10-01-10-37-02
screenshot_2014-10-01-10-33-00
screenshot_2014-10-01-10-34-28
screenshot_2014-10-01-10-34-40
screenshot_2014-10-01-10-34-04

@m4gr3d
Copy link
Member Author

m4gr3d commented Oct 1, 2014

@arthurbenemann sounds good. The circular buttons are an attempt to follow Android's updated material ui guidelines.
But it makes less sense to use it for multiple buttons since it takes more space.

@arthurbenemann arthurbenemann mentioned this pull request Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants