Actions Buttons improvements: Tablet only flight

[arthurbenemann]

Improved the functionality of #1090

[m4gr3d]

@arthurbenemann I was planning to tackle this issue along with issue #1092.
Instead of having one specific disarm button, we should have a generic anti button.
So for example:

• clicking on connect causes disconnect button and arm button to appear (connect replaced by arm)
• clicking on arm causes disarm button and takeoff button to appear (disconnect replaced by disarm and arm replaced by takeoff)
• clicking on takeoff causes the in flight action bar to appear. No anti button is needed here since you can land by clicking the land flight mode action button.

[arthurbenemann]

@ne0fhyk This achieves a similar result, without changing the structure that's in place now. I don't think there is a need for a disconnect button.

[m4gr3d]

@arthurbenemann an user was complaining a few weeks back about not being able to locate the disconnect option and wanted us to implement a fake menu to always hint at it.
It's likely then this has occurred to several more users since the majority of the devices running DP are samsung. Adding a disconnect button would solve that issue nicely without adding any kludge.

[m4gr3d]

@arthurbenemann also the structure (ui at least) of the flight action buttons will be updated to match with Google's updated design guide.

[arthurbenemann]

@ne0fhyk Disconnect isn't all that useful. Please give me a good reason to click the disconnect button?
And as we move to tablet only control, disconnect is one of the last things you want to happen.

In any case I'm merging this PR, as it's better than what we have currently. At least that was my experience when test flying some minutes ago.

[squilter]

We now have 2 "connect" buttons. Would it make sense to remove the top one?

[m4gr3d]

That makes sense on the flight screen, but the top one still needs to be available on the other screens.
Perhaps just set its showAsAction to never, this way it'll only show in the drop down menu.

[arthurbenemann]

I'll do that.

[m4gr3d]

On that note, is it crucial to have the action bar telemetry info visible in all the app screens?
Not having it in the Editor screen would free up valuable real estate in the action bar where the editor tools could be moved up.

[arthurbenemann]

I'm making the fixes here: #1109

@ne0fhyk I like having the telemetry information being consistent thought out the app. But you make a great point about the real state for things like send and receive waypoints in the editor.