Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mavlink library #1038

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

arthurbenemann
Copy link
Member

Updated the message_definitions files using current ArduPilot definitions.

Regenerated the message files using the pyMavlinkGenerator.

@arthurbenemann
Copy link
Member Author

@ne0fhyk Care to take a look at this PR? We need the new camera_feedback and terrain_following type messages.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 4, 2014

@arthurbenemann I'm on it.
By the way, what's the source for the mavlink java generator script. A javadoc should be added to the generated file(s) to notify the user they were generated automatically, and they should not be updated.

@arthurbenemann
Copy link
Member Author

The source for the generator is at :
https://github.com/DroidPlanner/droidplanner/blob/master/Mavlink/mavlinkGenerator/generateMessages.py

Some extra info at: https://github.com/DroidPlanner/droidplanner/blob/master/Mavlink/mavlinkGenerator/README.txt

The pymavlink code that we use is at:
https://github.com/DroidPlanner/mavlink

The correct way to do this would be to synchronize with the official MAVLink repo. Here is the PR mavlink/mavlink#246

@m4gr3d
Copy link
Member

m4gr3d commented Sep 4, 2014

@arthurbenemann this PR looks good. Are you done working on it? It is ready for a merge?

@m4gr3d
Copy link
Member

m4gr3d commented Sep 4, 2014

@arthurbenemann what issues is @LorenzMeier referring about for the mavlink/mavlink#246 PR.

Also, is there a reason why the generated classes name don't follow the java class name convention?

@arthurbenemann
Copy link
Member Author

I'm merging this PR.

@ne0fhyk The issues are just so it's compatible with the mavlink project.

arthurbenemann added a commit that referenced this pull request Sep 4, 2014
@arthurbenemann arthurbenemann merged commit 8892055 into DroidPlanner:master Sep 4, 2014
@arthurbenemann arthurbenemann deleted the mavlink_update branch September 4, 2014 16:16
@m4gr3d
Copy link
Member

m4gr3d commented Sep 4, 2014

@arthurbenemann is the class name convention also dictated by the mavlink project?
When I get some time, I might take a look at fixing up the mavlink project to incorporate the changes I mentioned, and sync it up with the official mavlink repo.

@arthurbenemann
Copy link
Member Author

@ne0fhyk Not really, but they want the generator to be generic (not just for the ardupilotmega dialect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants