-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mavlink library #1038
Update Mavlink library #1038
Conversation
@ne0fhyk Care to take a look at this PR? We need the new camera_feedback and terrain_following type messages. |
@arthurbenemann I'm on it. |
The source for the generator is at : Some extra info at: https://github.com/DroidPlanner/droidplanner/blob/master/Mavlink/mavlinkGenerator/README.txt The pymavlink code that we use is at: The correct way to do this would be to synchronize with the official MAVLink repo. Here is the PR mavlink/mavlink#246 |
@arthurbenemann this PR looks good. Are you done working on it? It is ready for a merge? |
@arthurbenemann what issues is @LorenzMeier referring about for the Also, is there a reason why the generated classes name don't follow the java class name convention? |
I'm merging this PR. @ne0fhyk The issues are just so it's compatible with the mavlink project. |
@arthurbenemann is the class name convention also dictated by the mavlink project? |
@ne0fhyk Not really, but they want the generator to be generic (not just for the ardupilotmega dialect). |
Updated the message_definitions files using current ArduPilot definitions.
Regenerated the message files using the pyMavlinkGenerator.