-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
traditional Chinese localization, string extraction, icon clone and resize #1021
Conversation
metalnow
commented
Aug 29, 2014
- add zh-tw for traditional Chinese Language
- extract some hard-code string to resource file
- clone rssi-icon to radio-icon and resize radio-icon to the same size with other menu-icon
add file for localization
1. move some hardcode string to xml for localization 2. add arrys.xml for traditional chinese localization
clone and resize radio icon for configuration list
@metalnow great job. Thanks for contribution! |
My pleasure. I am glad to help. Though, I am a newbie to github. If there is something wrong for my PR, feel free to comment it. I will do my best. |
@metalnow sorry for the delay, but I'm just getting to reviewing your PR now. I'll add comments if I find some issues. |
<?xml version="1.0" encoding="utf-8"?> | ||
<resources> | ||
|
||
<!-- Do not change the names here, instead extract the strings --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@metalnow as noted by the comment above, instead of repeating the content of this file, extract the string item in these string arrays to the strings.xml
file, and provide their translation in a matching localized strings.xml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey. I didn't notice that. I should be more careful.
@ne0fhyk I appreciated your review. After confirming the feedback, what should I do? Revise and put another PR, right? |
@metalnow you can commit the updates/fixes to the same branch, and it'll be automatically included as part of the current PR. |
@ne0fhyk Thank you for guidance. I updated the string.xml for chinese to the latest and remove array.xml from values-zh-rTW folder. I also simplify the code for accessing variable "drone" and String-resource. Please help me merging my PR. |
@metalnow thanks for the update. Everything looks good! |
traditional Chinese localization, string extraction, icon clone and resize