Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traditional Chinese localization, string extraction, icon clone and resize #1021

Merged
merged 10 commits into from
Sep 2, 2014

Conversation

metalnow
Copy link
Contributor

  1. add zh-tw for traditional Chinese Language
  2. extract some hard-code string to resource file
  3. clone rssi-icon to radio-icon and resize radio-icon to the same size with other menu-icon

add file for localization
1. move some hardcode string to xml for localization
2. add arrys.xml for traditional chinese localization
clone and resize radio icon for configuration list
@m4gr3d
Copy link
Member

m4gr3d commented Aug 29, 2014

@metalnow great job. Thanks for contribution!

@metalnow
Copy link
Contributor Author

My pleasure. I am glad to help. Though, I am a newbie to github. If there is something wrong for my PR, feel free to comment it. I will do my best.

@m4gr3d m4gr3d added the Feature label Sep 1, 2014
@m4gr3d m4gr3d self-assigned this Sep 1, 2014
@m4gr3d
Copy link
Member

m4gr3d commented Sep 1, 2014

@metalnow sorry for the delay, but I'm just getting to reviewing your PR now. I'll add comments if I find some issues.
Let me know if you have any question.

<?xml version="1.0" encoding="utf-8"?>
<resources>

<!-- Do not change the names here, instead extract the strings -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metalnow as noted by the comment above, instead of repeating the content of this file, extract the string item in these string arrays to the strings.xml file, and provide their translation in a matching localized strings.xml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey. I didn't notice that. I should be more careful.

@metalnow
Copy link
Contributor Author

metalnow commented Sep 2, 2014

@ne0fhyk I appreciated your review. After confirming the feedback, what should I do? Revise and put another PR, right?

@m4gr3d
Copy link
Member

m4gr3d commented Sep 2, 2014

@metalnow you can commit the updates/fixes to the same branch, and it'll be automatically included as part of the current PR.
Though, we won't get notified when you're all done, so let me know when your updates are complete. Thanks!

@metalnow
Copy link
Contributor Author

metalnow commented Sep 2, 2014

@ne0fhyk Thank you for guidance. I updated the string.xml for chinese to the latest and remove array.xml from values-zh-rTW folder. I also simplify the code for accessing variable "drone" and String-resource. Please help me merging my PR.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 2, 2014

@metalnow thanks for the update. Everything looks good!

m4gr3d added a commit that referenced this pull request Sep 2, 2014
traditional Chinese localization, string extraction, icon clone and resize
@m4gr3d m4gr3d merged commit d8c7880 into DroidPlanner:master Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants