Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #998. #1008

Merged
merged 1 commit into from
Aug 24, 2014
Merged

Fixes issue #998. #1008

merged 1 commit into from
Aug 24, 2014

Conversation

m4gr3d
Copy link
Member

@m4gr3d m4gr3d commented Aug 24, 2014

Fixes multiple issues with the way PR #997 was implemented.

<string name="pref_tts_periodic_key">tts_periodic</string>
<string name="pref_tts_periodic_period_key">tts_periodic_period</string>
<string name="pref_tts_periodic_period_key">tts_periodic_status_period</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TShapinsky I'm changing the key value because some devices might already have the default 'off' value stored in the shared preferences.

arthurbenemann added a commit that referenced this pull request Aug 24, 2014
@arthurbenemann arthurbenemann merged commit 1fbbb31 into DroidPlanner:master Aug 24, 2014
for (int i = 1; i < periodicSpeechPrefs.getPreferenceCount(); i++) {
periodicSpeechPrefs.getPreference(i).setEnabled(val != 0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TShapinsky here you're doing the same comparison several times. I pulled the result into a variable, and just referenced that.

@m4gr3d m4gr3d deleted the fix_issue_998 branch August 24, 2014 16:56
@TShapinsky
Copy link
Member

Thank you @ne0fhyk

TShapinsky added a commit to TShapinsky/droidplanner that referenced this pull request Aug 24, 2014
@squilter squilter mentioned this pull request Aug 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants