-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS - detailed infos triggered to close (queue) #1043
Comments
I agree that voltage doesn't need 3 decimal points. One is enough. Allowing different intervals for different values would just make a mess. If I read altitude every 5 seconds and battery every 12 seconds, which one is going to take priority at the 60 second mark? I'm also not really sure what advantage this would bring. If it ends up talking over itself, you should just increase the interval. The short interval is best if you are only interested in reading one value (i.e. voltage). You shouldn't use the short interval If you want the app to read every value that it is capable of reading. |
The issue here is that we are dropping the previous speech by use of This make sense for high priority events, but for status events, we should be queuing the messages instead by using |
Overloading High priority events will set |
Or just create a |
@arthurbenemann both methods will use the exact same logic except for the queuing parameter, so it's preferable to avoid duplicating logic. |
@ne0fhyk The worry here is that the user will request a periodic status update that takes 20 seconds to read, and they will set the interval to 15 seconds. If we |
@squilter in that case, we can use Toggle a flag when a speech is added, and reset it when it's done. While the current speech is not done, any non high priority events should be discarded. |
latest 2.4 fixed the issue.. only in 'vol-ts' is a small click/hickup.. |
if all speech outputs are enabled, the selected element output is too close to the next element.
result is that sometimes the voltage will override the altitute speech. this will cut the previous triggered output. please add some more milliseconds before the output of the next elements.. it seems they are triggered in row, without waiting for the last element to finish.
battery voltage reads three points after the comma? like 16.791¿ (maybe shorten to 2 digits?)
a global interval selection is already a nice thing, it would be great to have an advanced feature that will allow to have an individual interval for EACH selected element.
like:
altitude 15 sec
battery 30 sec
exception schould be LOSS or WARNINGS and FAILSAFE.. theese should get the highest priority...
The text was updated successfully, but these errors were encountered: