Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS - detailed infos triggered to close (queue) #1043

Closed
keyoss opened this issue Sep 3, 2014 · 8 comments
Closed

TTS - detailed infos triggered to close (queue) #1043

keyoss opened this issue Sep 3, 2014 · 8 comments
Assignees

Comments

@keyoss
Copy link

keyoss commented Sep 3, 2014

if all speech outputs are enabled, the selected element output is too close to the next element.
result is that sometimes the voltage will override the altitute speech. this will cut the previous triggered output. please add some more milliseconds before the output of the next elements.. it seems they are triggered in row, without waiting for the last element to finish.

battery voltage reads three points after the comma? like 16.791¿ (maybe shorten to 2 digits?)

a global interval selection is already a nice thing, it would be great to have an advanced feature that will allow to have an individual interval for EACH selected element.

like:
altitude 15 sec
battery 30 sec

exception schould be LOSS or WARNINGS and FAILSAFE.. theese should get the highest priority...

@squilter
Copy link
Member

squilter commented Sep 3, 2014

I agree that voltage doesn't need 3 decimal points. One is enough.

Allowing different intervals for different values would just make a mess. If I read altitude every 5 seconds and battery every 12 seconds, which one is going to take priority at the 60 second mark? I'm also not really sure what advantage this would bring.

If it ends up talking over itself, you should just increase the interval. The short interval is best if you are only interested in reading one value (i.e. voltage). You shouldn't use the short interval If you want the app to read every value that it is capable of reading.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 3, 2014

The issue here is that we are dropping the previous speech by use of QUEUE_FLUSH.

This make sense for high priority events, but for status events, we should be queuing the messages instead by using QUEUE_ADD.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 3, 2014

Overloading speak(...) with an additional parameter (speakNow?) should do the trick.

High priority events will set speakNow to true, while status events will set it to false.

@arthurbenemann
Copy link
Member

Or just create a speakNow method.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 3, 2014

@arthurbenemann both methods will use the exact same logic except for the queuing parameter, so it's preferable to avoid duplicating logic.
Unless speak is expanded to include the additional boolean parameter, and speakNow is just a delegate to it with the parameter set to true.

@squilter
Copy link
Member

squilter commented Sep 3, 2014

@ne0fhyk The worry here is that the user will request a periodic status update that takes 20 seconds to read, and they will set the interval to 15 seconds. If we QUEUE_ADD it, then the queue will grow faster than the lady can read it. After a few minutes it will just be reading really outdated info.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 3, 2014

@squilter in that case, we can use isSpeaking, or UtteranceProgressListener to figure out when the current speech is done.

Toggle a flag when a speech is added, and reset it when it's done. While the current speech is not done, any non high priority events should be discarded.

@m4gr3d m4gr3d self-assigned this Sep 4, 2014
m4gr3d added a commit to m4gr3d/droidplanner that referenced this issue Sep 4, 2014
arthurbenemann added a commit that referenced this issue Sep 4, 2014
@keyoss
Copy link
Author

keyoss commented Sep 9, 2014

latest 2.4 fixed the issue..

only in 'vol-ts' is a small click/hickup..

@keyoss keyoss changed the title Speech output for detailed infos: alt, airspeed etc triggered to close TTS - detailed infos triggered to close (queue) Sep 9, 2014
@keyoss keyoss closed this as completed Sep 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants