Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on connect #1033

Closed
keyoss opened this issue Sep 2, 2014 · 14 comments
Closed

Crash on connect #1033

keyoss opened this issue Sep 2, 2014 · 14 comments
Assignees
Labels

Comments

@keyoss
Copy link

keyoss commented Sep 2, 2014

java.lang.NullPointerException
at com.ftdi.j2xx.FT_Device.isOpen(FT_Device.java:487)
at com.ftdi.j2xx.FT_Device.openDevice(FT_Device.java:424)
at com.ftdi.j2xx.D2xxManager.tryOpen(D2xxManager.java:1065)
at com.ftdi.j2xx.D2xxManager.openByIndex(D2xxManager.java:1136)
at com.ftdi.j2xx.D2xxManager.openByIndex(D2xxManager.java:1151)
at org.droidplanner.android.communication.connection.UsbFTDIConnection.openAndroidConnection(UsbFTDIConnection.java:40)
at org.droidplanner.android.communication.connection.AndroidMavLinkConnection.openConnection(AndroidMavLinkConnection.java:57)
at org.droidplanner.core.MAVLink.connection.MavLinkConnection$1.run(MavLinkConnection.java:83)
at java.lang.Thread.run(Thread.java:856)

2.7.2 RC1-15

@m4gr3d m4gr3d added the bug label Sep 2, 2014
@m4gr3d m4gr3d self-assigned this Sep 2, 2014
@m4gr3d
Copy link
Member

m4gr3d commented Sep 2, 2014

@arthurbenemann the NPE is comming from the ftdi library. Do we have access to the source?
For now, I'm wrapping the call with a try...catch.

m4gr3d added a commit to m4gr3d/droidplanner that referenced this issue Sep 2, 2014
@m4gr3d
Copy link
Member

m4gr3d commented Sep 2, 2014

@keyoss does this happen all the time, or sporadically?
And what devices is this happening on?

@keyoss
Copy link
Author

keyoss commented Sep 2, 2014

Its on a KOBO Arc 10 HD
just the 3DR Telemtry connected

it happens ALWAYS..

the only working APK for now is the old 2.6.(1?)

@keyoss
Copy link
Author

keyoss commented Sep 2, 2014

the only release wich seems to work right now is 2.6.0 RC1

@m4gr3d
Copy link
Member

m4gr3d commented Sep 2, 2014

@arthurbenemann it's probably related to the change of usb drivers.

@m4gr3d m4gr3d assigned arthurbenemann and unassigned m4gr3d Sep 2, 2014
@keyoss
Copy link
Author

keyoss commented Sep 2, 2014

kobo android version is :
4.2.2

kernel
3.4.35

not rooted or modified

@arthurbenemann
Copy link
Member

@ne0fhyk We don't have access to the source of the FTDI library.

The library used for FTDI devices is now the D20XX library (form FTDI), because we where having problems with the open usb library.

@keyoss One possible solution is to add a setting that forces the app to always use the open usb-library.

arthurbenemann added a commit that referenced this issue Sep 2, 2014
@keyoss
Copy link
Author

keyoss commented Sep 2, 2014

i guess its managed by code?
i am not able to recompile anything at my side..

if its possible todo/change anything on my device.. tell me what to do, but keep in mind its not rooted... sadly

@arthurbenemann
Copy link
Member

@keyoss Yes, it needs to be modified on the code.

@m4gr3d
Copy link
Member

m4gr3d commented Sep 2, 2014

@keyoss I posted a debug version of the app with an updated usb connection layer for testing.
Could you try it out on your device, and let me know if that fixes your issue: https://github.com/ne0fhyk/droidplanner/releases/tag/v2.7.2.1

Bear in mind that you will have to uninstall the beta install (and thus lose saved preferences) in order to successfully install the debug release.

@keyoss
Copy link
Author

keyoss commented Sep 3, 2014

works! up and running for 4hours!
several restarts performed and several reconnects done... smooth as it should be!

i always deinstall, delete related folders, reboot, reinstall, reboot, run the software..
only thing i back up is the offlinemaps ;)
'approved alpha/betatester since stoneage' ;)

cool seems file can be closed!
thanks..!

@m4gr3d
Copy link
Member

m4gr3d commented Sep 3, 2014

That's great!
@keyoss Could you also check if you're successfully able to retrieve, and update the drone parameters.
@arthurbenemann I'll clean up the branch, and merge it into master before closing this issue.

@keyoss
Copy link
Author

keyoss commented Sep 3, 2014

@ne0fhyk directly after connection are parameters already loaded or where does the values come from?
i refreshed parameters and they are fast and successfully loaded.

did 3 restarts/coldstarts and also some close/open connections - close/open droidplanner and everytime successful and fast parameter download. tbh.. faster than before? and it doent stuck while downloading.
also i noticed it sometimes depends on the device power if it stucks at parameter refreshments, but this was the case with old DP versions.

btw: nice additions.. like calibration possibilitys etc ;)

@arthurbenemann
Copy link
Member

This has been fixed by #1042, thanks for reporting it @keyoss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants