[Improvement] introduce ScrollState#safeScroll #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
reviewed
Oct 10, 2022
| @@ -418,6 +417,21 @@ class ScreenScrollState( | |||
| } | |||
| } | |||
|
|
|||
| suspend fun safeScroll( | |||
There was a problem hiding this comment.
I didn't think it was our class. I think we can delete the safeScroll and use the implementation as the default implementation of the scroll method. Because it is scroll, so I think it can not be the critical feature.
What do you think?
But I think it is better than the current implementation. So please let me merge this for now!
There was a problem hiding this comment.
Thank you for your comment!
I've opened a PR for the rename and simplification #902
Sorry for bothering you 🙏🏻
|
Thank you for your cooperation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
I introduced a method ScrollState#safeScroll which is suggested in the comment https://github.com/DroidKaigi/conference-app-2022/pull/878/files#r990602724
Screenshot
No changed in behavior, so no screenshot.